Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34137 )
Change subject: soc/intel/common: Add function to check if PCI device is a LPSS controller ......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34137/5/src/soc/intel/common/block/... File src/soc/intel/common/block/include/intelblocks/lpss.h:
https://review.coreboot.org/c/coreboot/+/34137/5/src/soc/intel/common/block/... PS5, Line 35: int
unsigned int?
Ack
https://review.coreboot.org/c/coreboot/+/34137/5/src/soc/intel/common/block/... File src/soc/intel/common/block/lpss/lpss.c:
https://review.coreboot.org/c/coreboot/+/34137/5/src/soc/intel/common/block/... PS5, Line 83: int
Shouldn't this be unsigned int?
Ack