Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31561 )
Change subject: payloads/tianocore: Add option for custom bootsplash
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/#/c/31561/1/payloads/external/tianocore/Makefile
File payloads/external/tianocore/Makefile:
https://review.coreboot.org/#/c/31561/1/payloads/external/tianocore/Makefile...
PS1, Line 109: git checkout CorebootPayloadPkg/Logo/Logo.bmp > /dev/null 2>&1
It’s unlikely, but if changes were staged already, then this wouldn’t do anything. So, you could do `git checkout HEAD -- CorebootPayloadPkg/Logo/Logo.bmp` to get the version in the git repository.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31561
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I164f46777169801cff56633fd920bc81b7c8129a
Gerrit-Change-Number: 31561
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 24 Feb 2019 11:19:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
