Attention is currently required from: Yu-Ping Wu. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56543 )
Change subject: helpers: Add GENMASK macro ......................................................................
Patch Set 6: Code-Review+2
(1 comment)
File src/soc/mediatek/common/pll.c:
https://review.coreboot.org/c/coreboot/+/56543/comment/53240be3_3457576c PS5, Line 3: #include <commonlib/bsd/helpers.h>
Done. […]
In general, we try not to include commonlib headers directly, because which definitions are split out into commonlib (or commonlib/bsd) is an implementation detail that the including file doesn't really need to care about. We often have cases where some but not all definitions regarding a certain component or feature are split out (e.g. <cbfs.h> vs. <commonlib/bsd/cbfs_serialized.h>), and you don't want to have to change all files including something whenever you find that you want to factor some new parts of a certain header out into commonlib, so we just rely on chain-includes for that. <commonlib/helpers.h> doesn't directly have a non-commonlib wrapper file, but traditionally it has usually been chain-included through <types.h> (or <stddef.h> directly). (This is also because in POSIX certain things are in different headers for legacy reasons that make absolutely no sense to be separate -- e.g. why is size_t in <stddef.h> and not in <stdint.h>? We want to keep everything in the right POSIX place so that third-party code using coreboot headers like vboot can find them, but we also don't want to deal with all those inconsistencies in coreboot code, so <types.h> is a sort of catchall header for this kind of commonly used stuff.)
See also https://review.coreboot.org/plugins/gitiles/coreboot/+/refs/heads/master/Doc...