Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38883 )
Change subject: mb/apple: Add iMac13,1 (21.5-inch, Late 2012) ......................................................................
Patch Set 1:
(5 comments)
https://review.coreboot.org/c/coreboot/+/38883/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38883/1//COMMIT_MSG@23 PS1, Line 23:
How did you create the port?
It's a sandy/ivy board, so take a guess :)
https://review.coreboot.org/c/coreboot/+/38883/1//COMMIT_MSG@41 PS1, Line 41: Cirrrrrus
Just Cirrus for when searching commits for that vendor.
Yes, I know. I accidentally typo'd it with three R's, and when re-reading it I thought it sounded fun, so I added two additional R's. In any case, it's something that needs checking, so I might as well correct this as soon as I have tested it :D
https://review.coreboot.org/c/coreboot/+/38883/1//COMMIT_MSG@50 PS1, Line 50: - Booting enough to use SSH via Ethernet
What payload, and what Linux kernel?
SeaBIOS, with whatever kernel version Arch Linux has had at some point. I'm just going to put Arch Linux because the kernel version isn't always the same.
https://review.coreboot.org/c/coreboot/+/38883/1/src/mainboard/apple/imac13_... File src/mainboard/apple/imac13_1/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/38883/1/src/mainboard/apple/imac13_... PS1, Line 2: Late
This Late/Earty/Mid thing is always uppercase in Apple's product names.
Ack. Early, rather :P
https://review.coreboot.org/c/coreboot/+/38883/1/src/mainboard/apple/imac13_... File src/mainboard/apple/imac13_1/early_init.c:
https://review.coreboot.org/c/coreboot/+/38883/1/src/mainboard/apple/imac13_... PS1, Line 43: pci_write_config16(PCI_DEV(0, 0x1f, 0), 0x82, 0x3f0f);
Add a comment what this does?
I don't know, it just appeared there. In any case, I'll check the PCH datasheet to see if that is necessary.