build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34635 )
Change subject: mb/ocp/monolake: use RW_VPD to configure FSP UPD
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34635/1/src/mainboard/ocp/monolake/...
File src/mainboard/ocp/monolake/romstage.c:
https://review.coreboot.org/c/coreboot/+/34635/1/src/mainboard/ocp/monolake/...
PS1, Line 112: board_configure_upd, (void *)UpdData) == VPD_FAIL)
line over 96 characters
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34635
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id66c3a7a0992037f59685c0c9250f90aefc3f105
Gerrit-Change-Number: 34635
Gerrit-PatchSet: 1
Gerrit-Owner: jonzhang@fb.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: jonzhang@fb.com
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 30 Jul 2019 20:49:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment