Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45780 )
Change subject: amdfwtool: Remove the assumption of ROM_SIZE
......................................................................
Patch Set 3: Code-Review+2
if you move this patch before "amdfwtool: Clean up the Makefile of amdfwtool", you could drop the "-DCONFIG_ROM_SIZE=$(CONFIG_ROM_SIZE)" right away in the makefile change. both the current way and what i suggest are ok for me though
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45780
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I894e833ed23a7da38b36986b624e7dcdf1f4090c
Gerrit-Change-Number: 45780
Gerrit-PatchSet: 3
Gerrit-Owner: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 29 Sep 2020 15:58:40 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment