Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46390 )
Change subject: soc/mediatek/mt8192: Add auxadc driver
......................................................................
Patch Set 15:
(2 comments)
https://review.coreboot.org/c/coreboot/+/46390/15//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/46390/15//COMMIT_MSG@24
PS15, Line 24: Reference datasheet: AUXADC.pdf
Reference datasheet: RH-A-2020-0070, v1.0
https://review.coreboot.org/c/coreboot/+/46390/15/src/soc/mediatek/mt8192/au...
File src/soc/mediatek/mt8192/auxadc.c:
https://review.coreboot.org/c/coreboot/+/46390/15/src/soc/mediatek/mt8192/au...
PS15, Line 3: #include <device/mmio.h>
in alphabet order
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46390
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id4553e99c3578fa40e28b19a6e010b52650ba41e
Gerrit-Change-Number: 46390
Gerrit-PatchSet: 15
Gerrit-Owner: Yidi Lin
yidi.lin@mediatek.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Po Xu
jg_poxu@mediatek.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
felixsinger@posteo.net
Gerrit-CC: Hung-Te Lin
hungte@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 29 Oct 2020 10:17:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment