Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44570 )
Change subject: soc/mediatek/mt8192: Do dram full calibration
......................................................................
Patch Set 18: Code-Review+2
(2 comments)
https://review.coreboot.org/c/coreboot/+/44570/11/src/soc/mediatek/mt8192/Ma...
File src/soc/mediatek/mt8192/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/44570/11/src/soc/mediatek/mt8192/Ma...
PS11, Line 41: dram
The name "dram" won't modify, i think it can also stay here?
Given that we currently don't have plan to change this, should be fine to keep it in current shape until we've moved the whole calibration to a shared module.
https://review.coreboot.org/c/coreboot/+/44570/11/src/soc/mediatek/mt8192/me...
File src/soc/mediatek/mt8192/memory.c:
https://review.coreboot.org/c/coreboot/+/44570/11/src/soc/mediatek/mt8192/me...
PS11, Line 149: DRAM-K
stands for: dram calibration.
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44570
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2d4437a4e4c770de084927018d4dd3f2e8b87fb1
Gerrit-Change-Number: 44570
Gerrit-PatchSet: 18
Gerrit-Owner: CK HU
ck.hu@mediatek.com
Gerrit-Reviewer: Duan huayang
huayang.duan@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Xi Chen
xixi.chen@mediatek.com
Gerrit-Reviewer: Yidi Lin
yidi.lin@mediatek.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: huayang duan
huayangduan@gmail.com
Gerrit-Comment-Date: Wed, 28 Oct 2020 02:28:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Xi Chen
xixi.chen@mediatek.com
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment