Attention is currently required from: YH Lin, Tim Wawrzynczak, Marco Chen, Zhuohao Lee, Felix Held.
Mark Hsieh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59580 )
Change subject: mb/google/brya/var/gimble: Swap TPM I2C with touchscreen I2C
......................................................................
Patch Set 6:
(1 comment)
File src/mainboard/google/brya/variants/gimble/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/59580/comment/fb3a2cb0_821cc3d8
PS6, Line 189: chip drivers/i2c/tpm
: register "hid" = ""GOOG0005""
: register "irq" = "ACPI_IRQ_EDGE_LOW(GPP_A13_IRQ)"
: device i2c 50 on end
: end
: end
Do we need to consider the backward compatible for the existing board?
Hi Zhuohao,
Copy Tim comment : suppose that means right now we do not have a way to support a single build target having a different TPM bus.
Please refer to this change, thanks.
https://review.coreboot.org/c/coreboot/+/59473/3/src/mainboard/google/brya/K...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59580
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I26d059a7ea5a3fdf00de260214c00d3bba9aa7f7
Gerrit-Change-Number: 59580
Gerrit-PatchSet: 6
Gerrit-Owner: Mark Hsieh
mark_hsieh@wistron.corp-partner.google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Marco Chen
marcochen@google.com
Gerrit-Reviewer: Mark Hsieh
mark_hsieh@wistron.corp-partner.google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: YH Lin
yueherngl@google.com
Gerrit-Reviewer: Zhuohao Lee
zhuohao@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Anfernee Chen
anfernee_chen@wistron.corp-partner.google.com
Gerrit-CC: Ariel Fang
ariel_fang@wistron.corp-partner.google.com
Gerrit-CC: Casper Chang
casper_chang@wistron.corp-partner.google.com
Gerrit-CC: Malik Hsu
malik_hsu@wistron.corp-partner.google.com
Gerrit-CC: Scott Chao
scott_chao@wistron.corp-partner.google.com
Gerrit-CC: Terry Chen
terry_chen@wistron.corp-partner.google.com
Gerrit-CC: Will Tsai
will_tsai@wistron.corp-partner.google.com
Gerrit-Attention: YH Lin
yueherngl@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Marco Chen
marcochen@google.com
Gerrit-Attention: Zhuohao Lee
zhuohao@google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Thu, 25 Nov 2021 05:26:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Zhuohao Lee
zhuohao@google.com
Gerrit-MessageType: comment