Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35119 )
Change subject: soc/sifive/fu540: Support booting from SD card
......................................................................
Patch Set 7: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/35119/7/src/mainboard/sifive/hifive...
File src/mainboard/sifive/hifive-unleashed/media.c:
https://review.coreboot.org/c/coreboot/+/35119/7/src/mainboard/sifive/hifive...
PS7, Line 28: #define BLOCK_SIZE 512
where does that value come from? is it mmc specific?
https://review.coreboot.org/c/coreboot/+/35119/7/src/mainboard/sifive/hifive...
PS7, Line 121: case 6:
that should not compile...
Please add explicit /* fallthrough */ or /* fall-through */
It might be a good idea to use an enum instead of plain numbers.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35119
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I18948d31c0bf0bf9d641480a35fc710b9ee8ae84
Gerrit-Change-Number: 35119
Gerrit-PatchSet: 7
Gerrit-Owner: Xiang Wang
merle@hardenedlinux.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: Shawn C
citypw@hardenedlinux.org
Gerrit-Reviewer: Xiang Wang
merle@hardenedlinux.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 11 Sep 2019 09:13:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment