build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38472 )
Change subject: amd/agesa: Make BottomIo position configurable ......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/c/coreboot/+/38472/3/src/northbridge/amd/agesa/f... File src/northbridge/amd/agesa/family14/state_machine.c:
https://review.coreboot.org/c/coreboot/+/38472/3/src/northbridge/amd/agesa/f... PS3, Line 63: Post->MemConfig.BottomIo = MIN(0xE0, MAX(0x28, ((UINT16)(CONFIG_BOTTOMIO_POSITION >> 24) & 0xF8))); line over 96 characters
https://review.coreboot.org/c/coreboot/+/38472/3/src/northbridge/amd/agesa/f... File src/northbridge/amd/agesa/family15tn/state_machine.c:
https://review.coreboot.org/c/coreboot/+/38472/3/src/northbridge/amd/agesa/f... PS3, Line 33: Post->MemConfig.BottomIo = MIN(0xE0, MAX(0x28, ((UINT16)(CONFIG_BOTTOMIO_POSITION >> 24) & 0xF8))); line over 96 characters
https://review.coreboot.org/c/coreboot/+/38472/3/src/northbridge/amd/agesa/f... File src/northbridge/amd/agesa/family16kb/state_machine.c:
https://review.coreboot.org/c/coreboot/+/38472/3/src/northbridge/amd/agesa/f... PS3, Line 35: Post->MemConfig.BottomIo = MIN(0xE0, MAX(0x28, ((UINT16)(CONFIG_BOTTOMIO_POSITION >> 24) & 0xF8))); line over 96 characters