Jacob Garber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37767 )
Change subject: util/inteltool: correct typedef'ed rdmsr function for FreeBSD ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/37767/1/util/inteltool/Makefile File util/inteltool/Makefile:
https://review.coreboot.org/c/coreboot/+/37767/1/util/inteltool/Makefile@26 PS1, Line 26: CFLAGS += -Wno-unused-function
This is a cosmetic solution to hide useless output like ./inteltool. […]
I'm a little puzzled by why this is happening. As far as I can tell, this freebsd_rdmsr/rdmsr function is called in cpu.c, so there shouldn't be a warning...
https://review.coreboot.org/c/coreboot/+/37767/1/util/inteltool/inteltool.h File util/inteltool/inteltool.h:
https://review.coreboot.org/c/coreboot/+/37767/1/util/inteltool/inteltool.h@... PS1, Line 374: int freebsd_wrmsr(int addr, msr_t msr); I think these two prototypes can just be removed instead, since they aren't used outside of cpu.c (it doesn't make sense to declare a static function in a header anyway).