[coreboot-gerrit] Change in coreboot[master]: cpu/intel/model_206ax: Replace `generate_cstate_entries`

[Nico Huber (Code Review)]

Attention is currently required from: Patrick Rudolph, Angel Pons, Arthur Heymans.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49093 )

Change subject: cpu/intel/model_206ax: Replace `generate_cstate_entries`
......................................................................

Patch Set 2:

(2 comments)

Patchset:

PS2: 
Sorry, I thought it would be good to review and say something
here, but I might have made it worse...

File src/cpu/intel/model_206ax/acpi.c:

https://review.coreboot.org/c/coreboot/+/49093/comment/747f2725_8da28bf6 
PS2, Line 54: acpi_cstates
> yes, if acpi_cX >= ARRAY_SIZE(cpu->cstates)

Let's call it an out-of-bounds read. You can just add it to the condition

if (acpi_cstates[i] > 0 && acpi_cstates[i] < cpu_cstate_count)

We need to count first, though. `cpu->cstates` is 0 terminated. (Ugh, I don't
understand this indirection. It's a static array, why is it not declared
here?)(Also, why are those acpi_cstates `int` and not `unsigned`?)