Attention is currently required from: EricR Lai. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48446 )
Change subject: mb/google/brya: Add memory DQ map ......................................................................
Patch Set 5: Code-Review+2
(2 comments)
File src/mainboard/google/brya/variants/baseboard/include/baseboard/gpio.h:
https://review.coreboot.org/c/coreboot/+/48446/comment/91fbfa15_4dc55be6 PS5, Line 14: /* Memory configuration board straps */ Honestly, I think we don't need these GPIO_* macros here. These are used in just one place and if any variant wants to change this, they need to add #undef #define for each of the pins. I think let's drop it for now and any variant that wants to use these differently can provide a strong definition of `variant_memory_sku()`.
https://review.coreboot.org/c/coreboot/+/48446/comment/5a3017e9_c2a24ffe PS5, Line 20: GPIO_MEM_CH_SEL Same here. This is used in just one place. Let's just drop it from here for now.