Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41173 )
Change subject: mb/google/dedede: Add VCM and NVM entry for OV8856 sensor ......................................................................
Patch Set 6:
(2 comments)
https://review.coreboot.org/c/coreboot/+/41173/6/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/baseboard/include/baseboard/acpi/cam1.asl:
https://review.coreboot.org/c/coreboot/+/41173/6/src/mainboard/google/dedede... PS6, Line 236: Device (NVM0) No need to expose the NVM0 device through a package in CAM1's _DSD just like how it is done for VCM?
https://review.coreboot.org/c/coreboot/+/41173/6/src/mainboard/google/dedede... PS6, Line 298: 0x0D Not quite sure if the address lines are indexed from 0 to 0xD (i.e. 14 lines) or from 1 to 0xD (i.e. 13 lines). If 13 lines, is that sufficient to address the entire range 0x2800.