Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45415 )
Change subject: zork/var/ezkinil: Fix Touchscreen doesn't work on v3.6x rework board
......................................................................
Patch Set 2:
Here's a suggested commit message for merging early:
zork/var/ezkinil: Fix Touchscreen for schematic v3.6x
GPIO 90 (EN_PWR_TOUCHSCREEN) is set to PAD_GPO(GPIO_90, LOW), in
the trembyle baseboard code, but was overridden to PAD_NC(GPIO_90)
in the ezkinil-specific gpio configuration. This override causes
the touchscreen enable to fail.
Removing the PAD_NC() override code fixes the issue.
This is urgently needed to get an official build for the reworked
board and to unblock the production of the next boards. The
recently-introduced change that requires the fix is the new
schematic.
Obviously this fix is very limited in scope, affecting just the
ezkinil mainboard.
BRANCH=zork
BUG=b:168580357
TEST=Check Touchscreen function work
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45415
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id94dd63ba51759cebaf17779a5e659dbe0f1807f
Gerrit-Change-Number: 45415
Gerrit-PatchSet: 2
Gerrit-Owner: Lucas Chen
lucas.chen@quanta.corp-partner.google.com
Gerrit-Reviewer: Bhanu Prakash Maiya
bhanumaiya@google.com
Gerrit-Reviewer: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Josie Nordrum
josienordrum@google.com
Gerrit-Reviewer: Lucas Chen
lucas.chen@quanta.corp-partner.google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: Vincent Wang
vwang@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Eric Peers
epeers@google.com
Gerrit-CC: Teresa Tseng
teresa_tseng@quanta.corp-partner.google.com
Gerrit-Comment-Date: Wed, 16 Sep 2020 01:47:55 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment