[coreboot-gerrit] Change in coreboot[master]: cpu/x86/smm: Introduce SMM module loader version 2

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43684 )

Change subject: cpu/x86/smm: Introduce SMM module loader version 2
......................................................................

Patch Set 6: Code-Review+1

(3 comments)

https://review.coreboot.org/c/coreboot/+/43684/5/src/cpu/x86/mp_init.c 
File src/cpu/x86/mp_init.c:

https://review.coreboot.org/c/coreboot/+/43684/5/src/cpu/x86/mp_init.c@775 
PS5, Line 775: 	cpus = 1;
> This would be a performance and optimization setting. SMM is already very difficult to debug. […]

Sounds good

https://review.coreboot.org/c/coreboot/+/43684/5/src/cpu/x86/mp_init.c@782 
PS5, Line 782: cpus
> It shouldn't unless I missed something.  On line 794: […]

The original setting is the following:

.num_concurrent_save_states = 1,

https://review.coreboot.org/c/coreboot/+/43684/2/src/cpu/x86/smm/smm_module_... 
File src/cpu/x86/smm/smm_module_loaderv2.c:

https://review.coreboot.org/c/coreboot/+/43684/2/src/cpu/x86/smm/smm_module_... 
PS2, Line 15: uint8_t
> This is same as previous loader, so I didn't change anything. I left it as is.

What I mean is that since you're using `uint8_t` and friends, you should include <stdint.h> in this file