Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48364 )
Change subject: sb/intel/x/smbus.c: Factor out common code
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48364/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/48364/1//COMMIT_MSG@11
PS1, Line 11:
Tested?
I didn't test, but since I made sure the copies across southbridges were identical, I'm pretty sure it won't break anything. Also, I wouldn't know how to determine if this change causes any regressions, other than "breaks booting".
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48364
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4ab46750c6fb7f71cbd55848e79ecc3e44cbbd04
Gerrit-Change-Number: 48364
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 10 Dec 2020 15:59:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment