Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32076 )
Change subject: mb/protectli/vault: Add FW2B and FW4B Braswell based boards support ......................................................................
Patch Set 15: Code-Review+1
(5 comments)
https://review.coreboot.org/c/coreboot/+/32076/14/Documentation/mainboard/pr... File Documentation/mainboard/protectli/fw2b_fw4b.md:
https://review.coreboot.org/c/coreboot/+/32076/14/Documentation/mainboard/pr... PS14, Line 83: - mPCIe debug card connected to mSATA (mSATA slot has LPC signals routed,
Compared the pinout of FW6 (where LPC card works) with the schematics of FW2B/FW4B. […]
Weird. Maybe nobody is printing postcodes on brasswell
https://review.coreboot.org/c/coreboot/+/32076/7/src/mainboard/protectli/vau... File src/mainboard/protectli/vault/variants/fw2b/devicetree.cb:
PS7:
All settings are the same except one disabled PCIe RP. […]
Ack
https://review.coreboot.org/c/coreboot/+/32076/14/src/mainboard/protectli/va... File src/mainboard/protectli/vault_bsw/acpi_tables.c:
PS14:
I see many variants of the SPDX headers. […]
I'd use the more succint kind, it is more common in other places
https://review.coreboot.org/c/coreboot/+/32076/15/src/mainboard/protectli/va... File src/mainboard/protectli/vault_bsw/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/32076/15/src/mainboard/protectli/va... PS15, Line 27: Scope (_SB) { : Device (PCI0) Um, that brace on the same line as Scope looks weird...
How about using `Device (_SB.PCI0)` instead?
https://review.coreboot.org/c/coreboot/+/32076/14/src/mainboard/protectli/va... File src/mainboard/protectli/vault_bsw/variants/fw4b/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/32076/14/src/mainboard/protectli/va... PS14, Line 4: device pci 1c.2 on end # 8086 22cc - PCIe Root Port 3
There are 4 Intel NICs occupying all PCIe RPs. […]
Right, what's the case for FW2B? I see that its PCIe port is disabled.
If they use the same PCB, I would try leaving that port enabled so that both boards can use the same image. It should not be a problem, I guess.