Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36794 )
Change subject: mb/intel/coffeelake_rvp: Switch to override setup ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36794/4/src/mainboard/intel/coffeel... File src/mainboard/intel/coffeelake_rvp/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/36794/4/src/mainboard/intel/coffeel... PS4, Line 72: device domain 0 on IMHO Keeping track of which devices are enabled/disabled on the baseboard is rather cumbersome. Also, FSP UPD settings and devices on the devicetree need to be consistent: if a PCIe root port is enabled in an UPD, then its corresponding PCI device should be enabled.
To make things easier, I would suggest having always-on devices on the baseboard (e.g. host bridge, IGD, thermal devices, XHCI, SMBus...), and individual buses (e.g. PCIe root ports, I2C controllers, GSPI...) on each overridetree, with the corresponding UPD values.
Any thoughts on the matter?