build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36389 )
Change subject: WIP: Add configurable ramstage support for minimal PCI scanning ......................................................................
Patch Set 1:
(7 comments)
https://review.coreboot.org/c/coreboot/+/36389/1/src/device/pci_device.c File src/device/pci_device.c:
https://review.coreboot.org/c/coreboot/+/36389/1/src/device/pci_device.c@949 PS1, Line 949: if (!dev->ops && driver) code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/36389/1/src/device/pci_device.c@949 PS1, Line 949: if (!dev->ops && driver) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/36389/1/src/device/pci_device.c@949 PS1, Line 949: if (!dev->ops && driver) suspect code indent for conditional statements (8, 10)
https://review.coreboot.org/c/coreboot/+/36389/1/src/device/pci_device.c@950 PS1, Line 950: dev->ops = (struct device_operations *)driver->ops; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/36389/1/src/device/pci_device.c@950 PS1, Line 950: dev->ops = (struct device_operations *)driver->ops; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/36389/1/src/include/device/pci.h File src/include/device/pci.h:
https://review.coreboot.org/c/coreboot/+/36389/1/src/include/device/pci.h@42 PS1, Line 42: unsigned int always_scan : 1; /* scan even if MINIMAL_PCI is set */ code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/36389/1/src/include/device/pci.h@42 PS1, Line 42: unsigned int always_scan : 1; /* scan even if MINIMAL_PCI is set */ please, no spaces at the start of a line