Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33824 )
Change subject: mainboard/google/hatch: create akemi variant. ......................................................................
Patch Set 6:
(5 comments)
https://review.coreboot.org/c/coreboot/+/33824/6/src/mainboard/google/hatch/... File src/mainboard/google/hatch/Kconfig:
https://review.coreboot.org/c/coreboot/+/33824/6/src/mainboard/google/hatch/... PS6, Line 70: default "AKEMI TEST 4326" if BOARD_GOOGLE_AKEMI Can you please put this in alphabetical order here and for other configs below?
https://review.coreboot.org/c/coreboot/+/33824/6/src/mainboard/google/hatch/... File src/mainboard/google/hatch/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/33824/6/src/mainboard/google/hatch/... PS6, Line 9: config BOARD_GOOGLE_HATCH_WHL : bool "-> Hatch_whl" : select BOARD_GOOGLE_BASEBOARD_HATCH : select BOARD_ROMSIZE_KB_32768 : select SOC_INTEL_WHISKEYLAKE I believe you need to rebase on ToT
https://review.coreboot.org/c/coreboot/+/33824/6/src/mainboard/google/hatch/... PS6, Line 33: BOARD_GOOGLE_AKEMI same here
https://review.coreboot.org/c/coreboot/+/33824/6/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/akemi/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/33824/6/src/mainboard/google/hatch/... PS6, Line 38: .rise_time_ns = 50, : .fall_time_ns = 15, Can you please remove these if they are just being copied from hatch?
https://review.coreboot.org/c/coreboot/+/33824/6/src/mainboard/google/hatch/... PS6, Line 69: register "irq" = "ACPI_IRQ_EDGE_LOW(GPP_D21_IRQ)" You need to set the probed property since you have multiple touchpad devices defined here.