[coreboot-gerrit] Change in ...coreboot[master]: soc/intel/cannonlake: Clean up cannonlake_memcfg_init

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32513 )

Change subject: soc/intel/cannonlake: Clean up cannonlake_memcfg_init
......................................................................

Patch Set 3:

(1 comment)

+Subrata +Rizwan

https://review.coreboot.org/#/c/32513/3/src/soc/intel/cannonlake/include/soc... 
File src/soc/intel/cannonlake/include/soc/cnl_memcfg_init.h:

https://review.coreboot.org/#/c/32513/3/src/soc/intel/cannonlake/include/soc... 
PS3, Line 62: 	struct spd_info spd;
> How is it supposed to work then? […]

As far as I can tell, the SPDs being used for all CNL boards have the same length for different memory types. You can add a die() in case that assumption is broken.