Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31590 )
Change subject: google/kukui: Add panel config data for display ......................................................................
Patch Set 4:
(3 comments)
https://review.coreboot.org/#/c/31590/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31590/4//COMMIT_MSG@8 PS4, Line 8: You also add more code. Please elaborate in the commit message.
https://review.coreboot.org/#/c/31590/4/src/mainboard/google/kukui/mainboard... File src/mainboard/google/kukui/mainboard.c:
https://review.coreboot.org/#/c/31590/4/src/mainboard/google/kukui/mainboard... PS4, Line 48: Setup Set up
https://review.coreboot.org/#/c/31590/4/src/mainboard/google/kukui/mainboard... PS4, Line 62: mdelay(20); 20 ms delay is huge. Please comment, why this is needed, and in what spec it is required.