[coreboot-gerrit] Change in coreboot[master]: soc/intel/common/timer: Make TSC frequency calculation dynamically

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35148 )

Change subject: soc/intel/common/timer: Make TSC frequency calculation dynamically
......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/35148/4/src/soc/intel/common/block/... 
File src/soc/intel/common/block/timer/timer.c:

https://review.coreboot.org/c/coreboot/+/35148/4/src/soc/intel/common/block/... 
PS4, Line 94: 	return (core_crystal_nominal_freq_khz * cpuidr_15h.ebx /
> also check timerstamp_tick_freq_mhz() default its returning 0 as well so i believe returning 0 might […]

It's not a new requirement with my patch, TSC_MONOTONIC_TIMER hits div-by-zero if you return 0 from tsc_freq_mhz() and have TSC_CONSTANT_RATE=y. What kernel does with tsc is not in my interests.

What timestamp_tick_freq_mhz() returns is not used as divisor in coreboot codebase and 0 there actually has another special and documented meaning.