Attention is currently required from: Raul Rangel. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59550 )
Change subject: rules.h, thread.h, lib/cbfs: Add ENV_STAGE_SUPPORTS_COOP ......................................................................
Patch Set 1:
(1 comment)
File src/include/rules.h:
https://review.coreboot.org/c/coreboot/+/59550/comment/ff50f4b8_4cb2cb3f PS1, Line 306: ENV_ROMSTAGE I just realized there may be a bit of an issue with preloading in romstage in combination with VBOOT_STARTS_IN_ROMSTAGE... in that case, the vboot code is linked into the romstage and runs as part of the run_ramstage() call. As a result, the behavior of cbfs_boot_lookup() changes. So files preloaded before the vboot code runs would no longer be valid afterwards.
No platforms anybody still cares about today really use VBOOT_STARTS_IN_ROMSTAGE, but we shouldn't just leave a potential bug lying around... how about just preventing the issue by making this (ENV_ROMSTAGE && !CONFIG(VBOOT_STARTS_IN_ROMSTAGE)) here?