Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47067 )
Change subject: sc7180: Fix prefill requirement and correct the fetch start check
......................................................................
Patch Set 5: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/47067/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/47067/1//COMMIT_MSG@9
PS1, Line 9: With Innolux panel timings, the fetch_start has evaluated to be more than
: v_total which is invalid.
The patch set 5 reverted your changes again.
Sorry Paul, we need this patch really urgently and the time zone difference with India makes it hard to fix this quickly. I hope you won't mind if I let a few commit message grammar issues slip through this once.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47067
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If7624c0b28421759fdf47dd92f23214a78058199
Gerrit-Change-Number: 47067
Gerrit-PatchSet: 5
Gerrit-Owner: Ravi kumar
rbokka@codeaurora.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: mturney mturney
mturney@codeaurora.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Ravi Kumar Bokka
c_rbokka@qualcomm.corp-partner.google.com
Gerrit-CC: Vinod Polimera
vpolimer@qualcomm.corp-partner.google.com
Gerrit-Comment-Date: Mon, 02 Nov 2020 22:04:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Vinod Polimera
vpolimer@qualcomm.corp-partner.google.com
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment