build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29966 )
Change subject: TEMP: NOT FOR REVIEW: qualcomm/qcs405: Add support for USB host mode for mistral platform ......................................................................
Patch Set 13:
(7 comments)
https://review.coreboot.org/#/c/29966/13/src/mainboard/google/mistral/mainbo... File src/mainboard/google/mistral/mainboard.c:
https://review.coreboot.org/#/c/29966/13/src/mainboard/google/mistral/mainbo... PS13, Line 49: if (IS_ENABLED(CONFIG_CHROMEOS)) { code indent should use tabs where possible
https://review.coreboot.org/#/c/29966/13/src/mainboard/google/mistral/mainbo... PS13, Line 49: if (IS_ENABLED(CONFIG_CHROMEOS)) { please, no spaces at the start of a line
https://review.coreboot.org/#/c/29966/13/src/mainboard/google/mistral/mainbo... PS13, Line 50: /* Copy WIFI calibration data into CBMEM. */ code indent should use tabs where possible
https://review.coreboot.org/#/c/29966/13/src/mainboard/google/mistral/mainbo... PS13, Line 51: cbmem_add_vpd_calibration_data(); code indent should use tabs where possible
https://review.coreboot.org/#/c/29966/13/src/mainboard/google/mistral/mainbo... PS13, Line 51: cbmem_add_vpd_calibration_data(); please, no spaces at the start of a line
https://review.coreboot.org/#/c/29966/13/src/mainboard/google/mistral/mainbo... PS13, Line 52: } code indent should use tabs where possible
https://review.coreboot.org/#/c/29966/13/src/mainboard/google/mistral/mainbo... PS13, Line 52: } please, no spaces at the start of a line