Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44835 )
Change subject: src/{device,include}: Use PNP_IDX_EN instead of magic number
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/44835/2/src/device/pnp_device.c
File src/device/pnp_device.c:
https://review.coreboot.org/c/coreboot/+/44835/2/src/device/pnp_device.c@7
PS2, Line 7: #include <device/pnp.h>
humm, looks like <device/pnp.h> didn't use <device/pnp_def.h> ...
i'm not sure if it would be a good idea to remove device/pnp_def.h from device/pnp.h, but that discussion should happen on the other patch
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44835
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I68590605e261ecaace9f3cea28cfa6ec3b913a8a
Gerrit-Change-Number: 44835
Gerrit-PatchSet: 3
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 14 Sep 2020 19:33:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: HAOUAS Elyes
ehaouas@noos.fr
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment