[coreboot-gerrit] Change in coreboot[master]: soc/intel/common/block/acpi: Add provision to inject PCI PIRQ ACPI ma...

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34658 )

Change subject: soc/intel/common/block/acpi: Add provision to inject PCI PIRQ ACPI mapping
......................................................................

Patch Set 6:

(1 comment)

https://review.coreboot.org/c/coreboot/+/34658/5/src/soc/intel/common/block/... 
File src/soc/intel/common/block/acpi/acpi.c:

https://review.coreboot.org/c/coreboot/+/34658/5/src/soc/intel/common/block/... 
PS5, Line 242: 
             : 		acpigen_write_scope("\");
             : 		acpigen_write_name("PIRX");
             : 		acpigen_write_package(num_entries);
> I tried to scope it SB. […]

I think when you have the "External" declaration in the ASL, you need to also include the full scope, i.e., External(_SB.PCI0.PIRX) instead.  Could you try that?