Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/51201 )
Change subject: mb/google/dedede/var/blipper: Generate SPD ID for supported memory parts ......................................................................
mb/google/dedede/var/blipper: Generate SPD ID for supported memory parts
Add supported memory parts in the mem_parts_used.txt and generate the SPD ID for the memory parts. The memory parts being added are: MT53E512M32D2NP-046 WT:E K4U6E3S4AA-MGCR H9HCNNNBKMMLXR-NEE
BUG=None TEST=Build the blipper board.
Change-Id: Ia7e4c1d5c06013c1902816d6dcafb5a8a0386bb3 Signed-off-by: Zanxi Chen chenzanxi@huaqin.corp-partner.google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/51201 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Karthik Ramasubramanian kramasub@google.com --- M src/mainboard/google/dedede/variants/blipper/memory/Makefile.inc M src/mainboard/google/dedede/variants/blipper/memory/dram_id.generated.txt M src/mainboard/google/dedede/variants/blipper/memory/mem_parts_used.txt 3 files changed, 8 insertions(+), 13 deletions(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Karthik Ramasubramanian: Looks good to me, approved
diff --git a/src/mainboard/google/dedede/variants/blipper/memory/Makefile.inc b/src/mainboard/google/dedede/variants/blipper/memory/Makefile.inc index b0ca222..d0960c7 100644 --- a/src/mainboard/google/dedede/variants/blipper/memory/Makefile.inc +++ b/src/mainboard/google/dedede/variants/blipper/memory/Makefile.inc @@ -1,5 +1,5 @@ ## SPDX-License-Identifier: GPL-2.0-or-later ## This is an auto-generated file. Do not edit!! -## Add memory parts in mem_parts_used.txt and run spd_tools to regenerate.
-SPD_SOURCES = placeholder.spd.hex +SPD_SOURCES = +SPD_SOURCES += lp4x-spd-1.hex # ID = 0(0b0000) Parts = MT53E512M32D2NP-046 WT:E, K4U6E3S4AA-MGCR, H9HCNNNBKMMLXR-NEE diff --git a/src/mainboard/google/dedede/variants/blipper/memory/dram_id.generated.txt b/src/mainboard/google/dedede/variants/blipper/memory/dram_id.generated.txt index fa24790..0df7bfc 100644 --- a/src/mainboard/google/dedede/variants/blipper/memory/dram_id.generated.txt +++ b/src/mainboard/google/dedede/variants/blipper/memory/dram_id.generated.txt @@ -1 +1,4 @@ DRAM Part Name ID to assign +MT53E512M32D2NP-046 WT:E 0 (0000) +K4U6E3S4AA-MGCR 0 (0000) +H9HCNNNBKMMLXR-NEE 0 (0000) diff --git a/src/mainboard/google/dedede/variants/blipper/memory/mem_parts_used.txt b/src/mainboard/google/dedede/variants/blipper/memory/mem_parts_used.txt index e4258b5..47159f8 100644 --- a/src/mainboard/google/dedede/variants/blipper/memory/mem_parts_used.txt +++ b/src/mainboard/google/dedede/variants/blipper/memory/mem_parts_used.txt @@ -1,11 +1,3 @@ -# This is a CSV file containing a list of memory parts used by this variant. -# One part per line with an optional fixed ID in column 2. -# Only include a fixed ID if it is required for legacy reasons! -# Generated IDs are dependent on the order of parts in this file, -# so new parts must always be added at the end of the file! -# -# Generate an updated Makefile.inc and dram_id.generated.txt by running the -# gen_part_id tool from util/spd_tools/{ddr4,lp4x}. -# See util/spd_tools/{ddr4,lp4x}/README.md for more details and instructions. - -# Part Name +MT53E512M32D2NP-046 WT:E +K4U6E3S4AA-MGCR +H9HCNNNBKMMLXR-NEE