[coreboot-gerrit] Change in ...coreboot[master]: mediatek/mt8183: Calibrate vsim2 to 2.7 V

[hsin-hsiung wang (Code Review)]

hsin-hsiung wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32057 )

Change subject: mediatek/mt8183: Calibrate vsim2 to 2.7 V
......................................................................

Patch Set 7: Code-Review+1

(1 comment)

https://review.coreboot.org/#/c/32057/5/src/soc/mediatek/mt8183/mt6358.c 
File src/soc/mediatek/mt8183/mt6358.c:

https://review.coreboot.org/#/c/32057/5/src/soc/mediatek/mt8183/mt6358.c@786 
PS5, Line 786: 	vsim2_cali_0mv = (vsim2_cali_0mv > 6) ? (vsim2_cali_0mv - 6) : 0;
> I assume we've somehow made sure that this cannot run twice and subtract the value twice? Does this  […]

Hi Julius,
I think you're right. The patch is base on kukui board design, so I move the vsim2 calibration to platform initialization.
For your question, PMIC will be reset to default voltage on every boot.