Daisuke Nojiri has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32336 )
Change subject: google/kukui: Get write protection status from WP GPIO
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/32336/1/src/mainboard/google/kukui/chromeos....
File src/mainboard/google/kukui/chromeos.c:
https://review.coreboot.org/#/c/32336/1/src/mainboard/google/kukui/chromeos....
PS1, Line 36: !
You're negating here and also at line 47. Can you verify this is intended?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32336
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I75b98b1d587abe5e8cdf3df28ea661bc1ffa19f9
Gerrit-Change-Number: 32336
Gerrit-PatchSet: 1
Gerrit-Owner: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: You-Cheng Syu
youcheng@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Daisuke Nojiri
dnojiri@chromium.org
Gerrit-CC: Joel Kitching
kitching@google.com
Gerrit-CC: Tony Lin
tonycwlin@google.com
Gerrit-CC: Tristan Hsieh
tristan.shieh@mediatek.com
Gerrit-CC: YH Lin
yueherngl@chromium.org
Gerrit-Comment-Date: Wed, 17 Apr 2019 06:39:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment