Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35030 )
Change subject: soc/intel/skylake: Add Lewisburg PCH family SKUs ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35030/3/src/include/device/pci_ids.... File src/include/device/pci_ids.h:
https://review.coreboot.org/c/coreboot/+/35030/3/src/include/device/pci_ids.... PS3, Line 2716: #define PCI_DEVICE_ID_INTEL_LWB_C621 0xa1c1 : #define PCI_DEVICE_ID_INTEL_LWB_C622 0xa1c2 : #define PCI_DEVICE_ID_INTEL_LWB_C624 0xa1c3 : #define PCI_DEVICE_ID_INTEL_LWB_C625 0xa1c4 : #define PCI_DEVICE_ID_INTEL_LWB_C626 0xa1c5 : #define PCI_DEVICE_ID_INTEL_LWB_C627 0xa1c6 : #define PCI_DEVICE_ID_INTEL_LWB_C628 0xa1c7 : #define PCI_DEVICE_ID_INTEL_LWB_C629 0xa1ca
"PROD" missing
It seemed to me that its better to use the same style as other macros in pci_ids.h Ok, I fixed it
https://review.coreboot.org/c/coreboot/+/35030/2/src/include/device/pci_ids.... File src/include/device/pci_ids.h:
https://review.coreboot.org/c/coreboot/+/35030/2/src/include/device/pci_ids.... PS2, Line 2716: #define PCI_DEVICE_ID_INTEL_LWB_C621 0xa1c1
Add these IDs in soc/intel/common/block/lpc/lpc.c pci_device_ids[].
fixed. Thanks!