Attention is currently required from: Kangheui Won, Maulik V Vaghela, Tim Wawrzynczak, Paul Menzel, Nick Vaccaro, Michael Niewöhner, Andrey Petrov.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62942 )
Change subject: drivers/intel/fsp2_0: Add provision to extract FSP Performance Data
......................................................................
Patch Set 6:
(5 comments)
File src/drivers/intel/fsp2_0/Kconfig:
https://review.coreboot.org/c/coreboot/+/62942/comment/fb6a622f_e81e23f5
PS6, Line 362: P
TIMESTAMPS?
Ack
https://review.coreboot.org/c/coreboot/+/62942/comment/eec655f1_61f9375b
PS6, Line 363: bool
Shouldn't this be shown in menuconfig?
Ack
https://review.coreboot.org/c/coreboot/+/62942/comment/9e1d95a2_6b0a05ba
PS6, Line 365: timestamp
timestamps?
Ack
https://review.coreboot.org/c/coreboot/+/62942/comment/697e4015_1d7a0978
PS6, Line 368: SoC users requires to compile and generate FSP binary with `PcdFspPerformanceEnable`
: set to `TRUE`.
Mabye `To be able to use this, FSP has to be compiled with .... […]
Ack
File src/drivers/intel/fsp2_0/fsp_timestamp.c:
https://review.coreboot.org/c/coreboot/+/62942/comment/22cf1a79_af7182db
PS6, Line 82: |P
add a space, please
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62942
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia1b7f6b98bafeec0afe843f0f78c99c2f34f50b3
Gerrit-Change-Number: 62942
Gerrit-PatchSet: 6
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Michael Niewöhner
foss@mniewoehner.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Reka Norman
rekanorman@chromium.org
Gerrit-Attention: Kangheui Won
khwon@chromium.org
Gerrit-Attention: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Attention: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Comment-Date: Tue, 29 Mar 2022 07:29:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michael Niewöhner
foss@mniewoehner.de
Gerrit-MessageType: comment