Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35905 )
Change subject: mediatek/mt8183: keep XO_SOC always in Full Power Mode ......................................................................
Patch Set 2:
(4 comments)
https://review.coreboot.org/c/coreboot/+/35905/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35905/2//COMMIT_MSG@11 PS2, Line 11: test[1] Please add a space before [.
https://review.coreboot.org/c/coreboot/+/35905/2//COMMIT_MSG@11 PS2, Line 11: for the random failure of suspend resume test[1]. I’d still prefer more details, as I am unable to access the bug report.
https://review.coreboot.org/c/coreboot/+/35905/2//COMMIT_MSG@15 PS2, Line 15: [1] https://issuetracker.google.com/issues/136980838 I believe there is a tag for issues in the Google bug tracker.
https://review.coreboot.org/c/coreboot/+/35905/2/src/soc/mediatek/mt8183/rtc... File src/soc/mediatek/mt8183/rtc.c:
https://review.coreboot.org/c/coreboot/+/35905/2/src/soc/mediatek/mt8183/rtc... PS2, Line 416: * FIXME: Also keep XO_SOC always in Full Power Mode.
… to fix resume issues from suspend.
Also reference bug URL?