Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39287 )
Change subject: vendorcode/intel/fsp/fsp2_0/skylake_sp: update header files ......................................................................
Patch Set 1:
(4 comments)
https://review.coreboot.org/c/coreboot/+/39287/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39287/1//COMMIT_MSG@9 PS1, Line 9: Added Present tense.
https://review.coreboot.org/c/coreboot/+/39287/1//COMMIT_MSG@11 PS1, Line 11: Added Present tense.
https://review.coreboot.org/c/coreboot/+/39287/1/src/vendorcode/intel/fsp/fs... File src/vendorcode/intel/fsp/fsp2_0/skylake_sp/gpio_fsp.h:
https://review.coreboot.org/c/coreboot/+/39287/1/src/vendorcode/intel/fsp/fs... PS1, Line 2: Copyright (c) 2019-2020, Intel Corporation. All rights reserved.<BR> Remove the <BR> at the end.
https://review.coreboot.org/c/coreboot/+/39287/1/src/vendorcode/intel/fsp/fs... PS1, Line 28: **/ Make this a standard header license comment (asterisks in the beginning)?
Is the license coreboot compatible?