19 Apr
2023
19 Apr
'23
midnight
Attention is currently required from: Subrata Banik, Sean Rhodes, Arthur Heymans.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74432 )
Change subject: mb/starlabs/starbook: Add ramtop_cmos_offset ......................................................................
Patch Set 4: Code-Review+1
(1 comment)
File src/mainboard/starlabs/starbook/cmos.layout:
https://review.coreboot.org/c/coreboot/+/74432/comment/9b06e640_80be1494 PS2, Line 42: 800
The ramstop feature doesn't seem to use the option table API and I don't see […]
Seems good now, at least according to my theory. But please share your test results :)
--
To view, visit https://review.coreboot.org/c/coreboot/+/74432
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I88128d2c62bdc3246a3f30e768c353f0fe3faeb7
Gerrit-Change-Number: 74432
Gerrit-PatchSet: 4
Gerrit-Owner: Sean Rhodes sean@starlabs.systems
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Lean Sheng Tan sheng.tan@9elements.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Subrata Banik subi.banik@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Subrata Banik subi.banik@gmail.com
Gerrit-Attention: Sean Rhodes sean@starlabs.systems
Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz
Gerrit-Comment-Date: Tue, 18 Apr 2023 21:00:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Gerrit-MessageType: comment