Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34433 )
Change subject: mediatek/mt8183: support get current DRAM type
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34433/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/34433/2//COMMIT_MSG@9
PS2, Line 9: read the ramid to get the DRAM type of current platform
Please elaborate. May current guess, but no idea what `ram_code()` does actually.
The platform supports two DRAM types: discrete and EMCP. (What is that?) The type is encoded on the board by reading certain GPIOs. Add support for reading that.
https://review.coreboot.org/c/coreboot/+/34433/2//COMMIT_MSG@13
PS2, Line 13: pass
Verb?: passes
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34433
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icf875427347418f796cbf193070bf047844d2267
Gerrit-Change-Number: 34433
Gerrit-PatchSet: 2
Gerrit-Owner: huayang duan
huayangduan@gmail.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Sj Huang
sj.huang@mediatek.com
Gerrit-Reviewer: You-Cheng Syu
youcheng@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: huayang duan
huayangduan@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 22 Jul 2019 11:55:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment