Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41809 )
Change subject: lib/coreboot_table: Add Intel FSP version to coreboot table
......................................................................
Patch Set 16:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41809/16/src/commonlib/include/comm...
File src/commonlib/include/commonlib/coreboot_tables.h:
https://review.coreboot.org/c/coreboot/+/41809/16/src/commonlib/include/comm...
PS16, Line 82: LB_TAG_CMOS_OPTION_TABLE = 0x00c8,
: LB_TAG_OPTION = 0x00c9,
: LB_TAG_OPTION_ENUM = 0x00ca,
: LB_TAG_OPTION_DEFAULTS = 0x00cb,
: LB_TAG_OPTION_CHECKSUM = 0x00cc,
These are actually a group of tags starting from 200 (somehow this
information got lost during refactoring). The new entry should be added
above as 0x38.
And I would still prefer to use a vendor-neutral tag name, e.g.
`LB_TAG_PLATFORM_BLOB_VERSION`.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41809
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I92a13ca91b9f66a7517cfd6784f3f692ff34e765
Gerrit-Change-Number: 41809
Gerrit-PatchSet: 16
Gerrit-Owner: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Jingle Hsu
jingle_hsu@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Morgan Jang
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Patrick Georgi
pgeorgi@google.com
Gerrit-Comment-Date: Tue, 30 Jun 2020 19:06:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment