Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33018 )
Change subject: google/grunt: Update Samsung K4AAG165WB-MCTD SPD Module Part Number
......................................................................
Patch Set 2:
Patch Set 2: Code-Review-1
This will break identification of this chip on all boards. RO will still have the old part number, but RW will have the new part number. Mosys looks for the SPDs in RO and won't be able to find them because the part number is different. This is what led to b:123179815 on careena where the memory information isn't populated.
Hi Martin, so we'll need to separate this specific DRAM SPD for Careena only? thanks.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33018
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5037ddfa99d8509c8a84a575348f8ae8d61f38a1
Gerrit-Change-Number: 33018
Gerrit-PatchSet: 2
Gerrit-Owner: Kevin Chiu
Kevin.Chiu@quantatw.com
Gerrit-Reviewer: Kevin Chiu
Kevin.Chiu@quantatw.com
Gerrit-Reviewer: Kevin Chiu
kevin.chiu@quanta.corp-partner.google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 28 May 2019 14:32:46 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment