Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36827 )
Change subject: cpu/x86/smm: Improve SMRAM locking ......................................................................
Patch Set 16:
(6 comments)
https://review.coreboot.org/c/coreboot/+/36827/16//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/36827/16//COMMIT_MSG@13 PS16, Line 13: SMM_LOCK_ON_1ST suggestion: what about something like SMM_LOCK_EARLY?
https://review.coreboot.org/c/coreboot/+/36827/16//COMMIT_MSG@18 PS16, Line 18: SMM_LOCK_ON_2ND suggestion: what about SMM_LOCK_ON_MP_INIT
https://review.coreboot.org/c/coreboot/+/36827/16/src/cpu/x86/mp_init.c File src/cpu/x86/mp_init.c:
https://review.coreboot.org/c/coreboot/+/36827/16/src/cpu/x86/mp_init.c@1099 PS16, Line 1099: smm_close_2nd(); Just checking, is it OK to do this before `restore_default_smm_area()` ? The default function there memcpy()'s into SMM_DEFAULT_BASE
https://review.coreboot.org/c/coreboot/+/36827/16/src/cpu/x86/smm/smm_util.c File src/cpu/x86/smm/smm_util.c:
https://review.coreboot.org/c/coreboot/+/36827/16/src/cpu/x86/smm/smm_util.c... PS16, Line 7: smram_lock smm_lock
https://review.coreboot.org/c/coreboot/+/36827/16/src/cpu/x86/smm/smm_util.c... PS16, Line 66: if (lock_smm_on_exit()) `CONFIG(SMM_LOCK_ON_2ND) && lock_smm_on_exit()` ?
https://review.coreboot.org/c/coreboot/+/36827/16/src/cpu/x86/smm/smm_util.c... PS16, Line 76: if (lock_smm_on_exit()) `CONFIG(SMM_LOCK_ON_FINAL) && lock_smm_on_exit()` ?