Attention is currently required from: Bao Zheng, Felix Held.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63509 )
Change subject: util/amdfwtool: Maintain one copy of PSP Level2 entries
......................................................................
Patch Set 3:
(1 comment)
File util/amdfwtool/amdfwtool.c:
https://review.coreboot.org/c/coreboot/+/63509/comment/bb2d99f0_d241df28
PS2, Line 1855: /* B is same as above directories for A */
: /* Skip creating pspdir2_b here to save flash space. Related
: * biosdir2_b will be skipped automatically. */
looks like this comment is wrong, so it would be good to fix this too
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63509
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I06eef8e14b9c14db1d02b621c2f7207188d86326
Gerrit-Change-Number: 63509
Gerrit-PatchSet: 3
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Avinash Alevoor
Gerrit-CC: Karthikeyan Ramasubramanian
kramasub@chromium.org
Gerrit-CC: Mohan Viswanathan
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Bao Zheng
fishbaozi@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 12 Apr 2022 23:42:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment