Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/18499 )
Change subject: libpayload: Use interrupt transfers for USB hubs ......................................................................
Patch Set 4:
(3 comments)
Thanks for the comments :)
https://review.coreboot.org/c/coreboot/+/18499/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/18499/3//COMMIT_MSG@2 PS3, Line 2: Author: Nico Huber nico.huber@secunet.com : AuthorDate: 2013-06-12 16:06:08 +0200 : Commit: Nico Huber nico.huber@secunet.com : CommitDate: 2019-08-12 13:27:47 +0200
6 years, 2 months. […]
Ack
https://review.coreboot.org/c/coreboot/+/18499/3/payloads/libpayload/drivers... File payloads/libpayload/drivers/usb/usbhub.c:
https://review.coreboot.org/c/coreboot/+/18499/3/payloads/libpayload/drivers... PS3, Line 308: div_round_up(desc.bNbrPorts + 1, 8)
BTW, Linux says here (hub.c#hub_configure()) […]
Done
https://review.coreboot.org/c/coreboot/+/18499/3/payloads/libpayload/drivers... PS3, Line 310: return;
Doesn't this need a usb_detach_device()? (I guess technically that was already wrong for generic_hub […]
Done