Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/75029?usp=email )
Change subject: mb/prodrive: Move selects from Kconfig.name to Kconfig ......................................................................
mb/prodrive: Move selects from Kconfig.name to Kconfig
Selects should be done in the Kconfig file instead of Kconfig.name and not mixed over both files.
Change-Id: Iface0fd1d44649c6d9773940818e028e3d3a4292 Signed-off-by: Felix Singer felixsinger@posteo.net Reviewed-on: https://review.coreboot.org/c/coreboot/+/75029 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Martin L Roth gaumless@gmail.com --- M src/mainboard/prodrive/atlas/Kconfig M src/mainboard/prodrive/atlas/Kconfig.name M src/mainboard/prodrive/hermes/Kconfig M src/mainboard/prodrive/hermes/Kconfig.name 4 files changed, 6 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Martin L Roth: Looks good to me, approved
diff --git a/src/mainboard/prodrive/atlas/Kconfig b/src/mainboard/prodrive/atlas/Kconfig index 5761fad..e4be946 100644 --- a/src/mainboard/prodrive/atlas/Kconfig +++ b/src/mainboard/prodrive/atlas/Kconfig @@ -12,6 +12,9 @@ select PCIEXP_SUPPORT_RESIZABLE_BARS select SOC_INTEL_ALDERLAKE_PCH_P
+config BOARD_PRODRIVE_ATLAS + select BOARD_PRODRIVE_ATLAS_BASEBOARD + if BOARD_PRODRIVE_ATLAS_BASEBOARD
config ATLAS_ENABLE_SAGV diff --git a/src/mainboard/prodrive/atlas/Kconfig.name b/src/mainboard/prodrive/atlas/Kconfig.name index f4304a0..722f0e5 100644 --- a/src/mainboard/prodrive/atlas/Kconfig.name +++ b/src/mainboard/prodrive/atlas/Kconfig.name @@ -1,3 +1,2 @@ config BOARD_PRODRIVE_ATLAS bool "Atlas" - select BOARD_PRODRIVE_ATLAS_BASEBOARD diff --git a/src/mainboard/prodrive/hermes/Kconfig b/src/mainboard/prodrive/hermes/Kconfig index e4ccd2d..0a0db36 100644 --- a/src/mainboard/prodrive/hermes/Kconfig +++ b/src/mainboard/prodrive/hermes/Kconfig @@ -18,6 +18,9 @@ select HAVE_ACPI_RESUME if !HERMES_USES_SPS_FIRMWARE select DISABLE_ACPI_HIBERNATE if HERMES_USES_SPS_FIRMWARE
+config BOARD_PRODRIVE_HERMES + select BOARD_PRODRIVE_HERMES_BASEBOARD + if BOARD_PRODRIVE_HERMES_BASEBOARD
config HERMES_USES_SPS_FIRMWARE diff --git a/src/mainboard/prodrive/hermes/Kconfig.name b/src/mainboard/prodrive/hermes/Kconfig.name index 10dd9ba..4aff62f 100644 --- a/src/mainboard/prodrive/hermes/Kconfig.name +++ b/src/mainboard/prodrive/hermes/Kconfig.name @@ -1,3 +1,2 @@ config BOARD_PRODRIVE_HERMES bool "Hermes" - select BOARD_PRODRIVE_HERMES_BASEBOARD