Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43607 )
Change subject: soc/intel/tigerlake: Set power limits for Tiger Lake Y-SKU ......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/c/coreboot/+/43607/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43607/2//COMMIT_MSG@9 PS2, Line 9: varaints
variants
Done
https://review.coreboot.org/c/coreboot/+/43607/2//COMMIT_MSG@10 PS2, Line 10:
Can you also mention that you set up power limits for Volteer boards that use the -Y SKU?
Done
https://review.coreboot.org/c/coreboot/+/43607/2/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/43607/2/src/mainboard/google/voltee... PS2, Line 214: register "power_limits_config[POWER_LIMITS_U_2_CORE]" = "{
My understanding is that these limits were derived for the Volteer platform, one set of limits for e […]
Yes these are baseline values for U/Y SKU type variants. We might need tuning later based on system design.