Hello Yu-Ping Wu, Julius Werner, Arthur Heymans, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/37262
to look at the new patch set (#9).
Change subject: util: cbfstool: Add '%<alignment>' in flashmap descriptor ......................................................................
util: cbfstool: Add '%<alignment>' in flashmap descriptor
Most FMAP sections that need to be updated independently should be aligned to erase block size (e.g., 4k), otherwise power failure during update may corrupt other sections.
Flashmap descriptor (FMD) today allows implicit offset and size, so sometimes we may make few sections being unaligned unexpectedly if there is no build time checks.
Since most sections (especially in chromeos.fmd) do need alignment, the patch is assuming "aligned" as default. For sections that don't need to be aligned (or aligned to different values), use the '%<num>' after section name / offset explicitly to change alignment, for example '%0' for unaligned. For example:
FMAP@0x1000 %0 0x800
Declared FMAP section to be in offset 0x1000, size 0x800, and no need to be aligned.
COREBOOT(CBFS)%0
Declared the CBFS section to be not aligned, using auto offset/size.
Since most boards already have CBFS and FMAP being unaligned, the patch only gives warning when unaligned sections were found. Follow up patches will fix FMD files, and eventually change warning to error.
TEST=make -j # pass
Change-Id: I26b394590c28667a4afcd521c7caa2009b5b98a9 Signed-off-by: Hung-Te Lin hungte@chromium.org --- M Documentation/lib/flashmap.md M util/cbfstool/default-x86.fmd M util/cbfstool/default.fmd M util/cbfstool/fmap_from_fmd.c M util/cbfstool/fmd.h M util/cbfstool/fmd_parser.c_shipped M util/cbfstool/fmd_parser.h_shipped M util/cbfstool/fmd_parser.y M util/cbfstool/fmd_scanner.c_shipped M util/cbfstool/fmd_scanner.h_shipped M util/cbfstool/fmd_scanner.l 11 files changed, 621 insertions(+), 412 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/37262/9