Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38471 )
Change subject: soc/amd/picasso: Add SMMSTORE support
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38471/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/38471/1//COMMIT_MSG@12
PS1, Line 12: duplicates
Hmmmmm... […]
I was thinking the same thing, perhaps an soc/amd/common layout to mimic what's done on the Intel side?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38471
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id05b33edf949611c3f9eac94e7b63a4266c6c4d0
Gerrit-Change-Number: 38471
Gerrit-PatchSet: 1
Gerrit-Owner: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Sun, 19 Jan 2020 18:07:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment