Attention is currently required from: Angel Pons. Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59517 )
Change subject: security/intel/txt: Use set_global_reset in txt_reset_platform if possible ......................................................................
Patch Set 6:
(2 comments)
Commit Message:
PS3:
This change does two things: […]
Split into two: - CB:59517 security/intel/txt: Use set_global_reset in txt_reset_platform if possible - CB:59639 security/intel/txt: Issue a global reset when TXT_RESET bit is set
File src/security/intel/txt/getsec.c:
https://review.coreboot.org/c/coreboot/+/59517/comment/8e99a56a_1992c1d0 PS3, Line 71: txt_reset_platform();
No, a global reset is not necessary here. This is just to unlock the IA32_FEATURE_CONTROL MSR.
True. Reverted here. But still I have changed to global reset in romstage (CB:59639) when TXT_RESET bit is st, since all implementations from Intel do that.