Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39346 )
Change subject: soc/intel/common: add processor power limits control support ......................................................................
Patch Set 24:
(3 comments)
https://review.coreboot.org/c/coreboot/+/39346/24/src/soc/intel/common/block... File src/soc/intel/common/block/include/intelblocks/power_limit.h:
https://review.coreboot.org/c/coreboot/+/39346/24/src/soc/intel/common/block... PS24, Line 1: /* : * This file is part of the coreboot project. : * : * Copyright (C) 2020 Intel Corporation : * : * This program is free software; you can redistribute it and/or modify : * it under the terms of the GNU General Public License as published by : * the Free Software Foundation; version 2 of the License. : * : * This program is distributed in the hope that it will be useful, : * but WITHOUT ANY WARRANTY; without even the implied warranty of : * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the : * GNU General Public License for more details. : */ coreboot now uses SPDX headers:
/* This file is part of the coreboot project. */ /* SPDX-License-Identifier: GPL-2.0-or-later */
https://review.coreboot.org/c/coreboot/+/39346/24/src/soc/intel/common/block... PS24, Line 25: nit: extra tab
https://review.coreboot.org/c/coreboot/+/39346/24/src/soc/intel/common/block... File src/soc/intel/common/block/power_limit/power_limit.c:
https://review.coreboot.org/c/coreboot/+/39346/24/src/soc/intel/common/block... PS24, Line 14: */ coreboot now uses SPDX headers:
/* This file is part of the coreboot project. */ /* SPDX-License-Identifier: GPL-2.0-or-later */